review

Change-Id: If2851ab9208981fe09a32d0016e7559cec588cd0 Signed-off-by: Kuat Yessenov <[email protected]>
kyessenov · Jul 12, 2024 · 549884f · 549884f
1 parent 8b03557
commit 549884f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/source/common/config/utility.h b/source/common/config/utility.h
@@ -299,9 +299,9 @@ class Utility {
    * @param typed_config for the extension config.
    */
   static std::string getFactoryType(const ProtobufWkt::Any& typed_config) {
-    static const std::string& typed_struct_type =
+    static const std::string typed_struct_type =
         xds::type::v3::TypedStruct::default_instance().GetTypeName();
-    static const std::string& legacy_typed_struct_type =
+    static const std::string legacy_typed_struct_type =
         udpa::type::v1::TypedStruct::default_instance().GetTypeName();
     // Unpack methods will only use the fully qualified type name after the last '/'.
     // https://github.com/protocolbuffers/protobuf/blob/3.6.x/src/google/protobuf/any.proto#L87

diff --git a/source/common/upstream/upstream_impl.cc b/source/common/upstream/upstream_impl.cc
@@ -1298,7 +1298,7 @@ ClusterInfoImpl::ClusterInfoImpl(
   if (http_protocol_options_) {
     Http::FilterChainUtility::FiltersList http_filters = http_protocol_options_->http_filters_;
     has_configured_http_filters_ = !http_filters.empty();
-    static const std::string& upstream_codec_type_url =
+    static const std::string upstream_codec_type_url =
         envoy::extensions::filters::http::upstream_codec::v3::UpstreamCodec::default_instance()
             .GetTypeName();
     if (http_filters.empty()) {