-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nullable colums for subqueries in left and full joins #1462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the current approach taken in this PR isn't going to work. The sample query added to the left join test is helpful to identify the problem.
I made some changes. Would this approach work better? |
I've tried to run the sql query but I seem unable to make it work as is. Could you check it ? |
here is fixed fiddle https://www.db-fiddle.com/f/f8yeYgvggnmw1t7p3M5YE6/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this trying to fix the same problem as #1486? If not, I'd like to merge that first before we continue working on this change.
You have some merge conflicts here. Can you rebase?
nullableNodes are used to identify their children and set columns to nullable
As @sbres pointed out they are fixing a different issue. This PR is trying to solve an issue with nested select statements where an information is lost about the parent being join that should produce nullable results. |
I think this fix is what we need to solve #1334 |
There is an issue when performing join on subquery. Fields that should be nullable are not because node is processed as ordinary select node. This pull request fixes the issue.