-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/nullable joins #1486
Fix/nullable joins #1486
Conversation
- The lack of this field creates an issue for queries using wildcard for select. When comparing `*n.Alias.Aliasname == col.TableAlias` isTableRequired would always return not found
bbea21a
to
c6e5297
Compare
This where breaking before, like this there is am example for make test-endtoend to detect
Depends on #1488 for test to run properly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You sadly have a set of merge conflicts now. Can you re-request a review from me when things are mergeable?
if n, ok := item.(*ast.String); ok { | ||
items = append(items, n.Str) | ||
continue | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why this needs to be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at the full function the condition is there twice.
I was tidying a little bit the code, it does not impact anything.
func stringSlice(list *ast.List) []string {
items := []string{}
for _, item := range list.Items {
if n, ok := item.(*ast.String); ok {
items = append(items, n.Str)
continue
}
if n, ok := item.(*ast.String); ok {
items = append(items, n.Str)
continue
}
Maybe we should just close this PR as #1491 already fixes the same thing and was merged right away |
This PR should fix #1334 and #1349
Columns with star reference were lacking the TableAlias attribute. Now it's set to t.Rel.Name like in expand()