Support UNION query (Postgres + MySQL) #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for UNION query in the compiler. It adds test cases for UNION in a SELECT and in a recursive CTE.
This commit adds enum values for SetOperation. The values are extracted from
the parser sources in pg_query_go:
typedef enum SetOperation
{
SETOP_NONE = 0,
SETOP_UNION,
SETOP_INTERSECT,
SETOP_EXCEPT
} SetOperation;
aitva
force-pushed
the
union-support-mysql
branch
from
86e579d
to
b752ff0
Compare
|
I noticed #867 and I have added unit tests to ensure that INTERSECT and EXCEPT are working. |
|
@aitva Thanks for the great contribution! Really appreciate all the tests you've added |
This was referenced Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a follow up on #790, I have implemented UNION support for MySQL. This pull request contains changes to the
compiler, new test cases, and changes toengine/dolphin. I cleaned up the commit history to fit the changes in 3 commits.If it is OK, we can close #790 and replace it by this pull request. It should fix #568, #709, #723 and #843.