Support UNION queries #790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for `UNION` in `internal/compiler`. It also adds test cases for `UNION` in a `SELECT` and in a `WITH RECURSIVE` query. It fixes sqlc-dev#568, sqlc-dev#723 and sqlc-dev#778.
|
I have noticed that there are TODOs in |
|
I don’t think anyone is. Sorry I haven’t had a chance to review this yet.
…On Tue, Dec 1, 2020 at 12:55 PM Aitva ***@***.***> wrote:
I have noticed that there are TODOs in engine/dolphin to add UNION
support for MySQL and I think I can make it work. @kyleconroy
<https://github.com/kyleconroy>, do you know if someone is working on it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#790 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAIQTLCEGFTU2GTLYWEQ3TSSVJ4JANCNFSM4TZAASCQ>
.
|
|
No problem, I am not in a rush. You can review this PR when you have time and I will send you another one when I have something working for MySQL. |
This commit adds enum values for SetOperation. The values are extracted from
the parser sources in pg_query_go:
typedef enum SetOperation
{
SETOP_NONE = 0,
SETOP_UNION,
SETOP_INTERSECT,
SETOP_EXCEPT
} SetOperation;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for queries with an
UNIONkeyword. I found a way to support them with a small update tointernal/compiler.I noticed that an
UNIONchanges howast.SelectStmtis parsed:TargetListfield is emptyLargandRargfields contain the two part of the unionBy changing
outputColumnsto look at theLargfield whenTargetListis empty, the columns are returned and the code generation succeed.I have added test cases for a
SELECTwith anUNIONand aWITH RECURSIVEquery.It should fix #568, #723 and #778.