Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tooltips for other resource forms #3448

Merged
merged 5 commits into from
Nov 14, 2024
Merged

feat: add tooltips for other resource forms #3448

merged 5 commits into from
Nov 14, 2024

Conversation

chriskari
Copy link
Contributor

@chriskari chriskari commented Nov 4, 2024 •
edited
Loading

Changes proposed in this pull request:

  • added tooltips to other resource forms
  • bugfix: update schema context when the current resource changes
  • adjusted tests

Related issue(s)
#3290

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 4, 2024
@chriskari chriskari linked an issue Nov 4, 2024 that may be closed by this pull request
Implement tooltip for other resource forms #3290
Closed
13 tasks
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2024
akucharska
akucharska requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@akucharska akucharska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks nice on create form, but for some reason we don't have tooltips on edit

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 13, 2024
@akucharska akucharska merged commit c2514aa into kyma-project:main Nov 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akucharska akucharska akucharska approved these changes

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@akucharska akucharska

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement tooltip for other resource forms
3 participants
@chriskari @akucharska @kyma-bot