Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction for #344 - shootAndSeedSameRegion in GardenerConfigInput #3443

Merged
merged 2 commits into from
May 29, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented May 29, 2024

Description

Changes proposed in this pull request:

  • Put shootAndSeedSameRegion field to GardenerConfigInput instead of GardenerConfig.

Related issue(s)

kyma-project/kyma#18182

@ralikio ralikio requested a review from a team as a code owner May 29, 2024 13:37
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label May 29, 2024
@ralikio ralikio changed the title Features/shoot and seed update 2 Correction for #344 - shootAndSeedSameRegion in GardenerConfigInput May 29, 2024
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 29, 2024
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label May 29, 2024
@ralikio ralikio added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 29, 2024
@kyma-bot kyma-bot merged commit c4ef757 into kyma-project:main May 29, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants