Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Telemetry module as a prerequisite for observability examples #271

Merged

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Sep 22, 2023

Description

Changes proposed in this pull request:

  • add a prerequisite to ensure that the Telemetry module is enabled for the following examples: jaeger, loki and trace-demo

Related issue(s)

kyma-project/kyma#18190

@shorim shorim added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/telemetry Issues or PRs related to the telemetry module kind/chore Categorizes issue or PR as related to a chore. labels Sep 22, 2023
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2023
@shorim shorim added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 22, 2023
chrkl
chrkl previously approved these changes Sep 22, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 22, 2023
@shorim shorim removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2023
jaeger/README.md Outdated Show resolved Hide resolved
loki/README.md Outdated Show resolved Hide resolved
trace-demo/README.md Outdated Show resolved Hide resolved
apply review suggestions

Co-authored-by: Grzegorz Karaluch <[email protected]>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 22, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 22, 2023
@kyma-bot kyma-bot merged commit 89a6c76 into kyma-project:main Sep 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/telemetry Issues or PRs related to the telemetry module kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants