Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to make migrator up to date #329

Merged
merged 12 commits into from
Aug 20, 2024
Merged

Fixes to make migrator up to date #329

merged 12 commits into from
Aug 20, 2024

Conversation

akgalwas
Copy link
Contributor

@akgalwas akgalwas commented Aug 6, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Migrator:
    • Adding label to say KIM should create shoot
    • Fixed spec.controlPlane field handling to allow providing empty value
    • Added networking type
  • Comparator:
    • Skipping TypeMeta comparison as the Provisioner's converter doesn't set kind, and apiVersion fields
    • Prepared custom matcher to compare extension list

Related issue(s)
#342

@akgalwas akgalwas requested a review from a team as a code owner August 6, 2024 15:11
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Aug 6, 2024
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 6, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2024
@akgalwas akgalwas changed the title [WiP] Fixes to make migrator up to date Fixes to make migrator up to date Aug 12, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2024
@Disper Disper self-assigned this Aug 19, 2024
m00g3n
m00g3n approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 20, 2024
@kyma-bot kyma-bot merged commit b1440d7 into kyma-project:main Aug 20, 2024
8 checks passed
@akgalwas akgalwas mentioned this pull request Aug 22, 2024
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00g3n m00g3n m00g3n approved these changes

Assignees

@Disper Disper

@m00g3n m00g3n

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akgalwas @m00g3n @Disper @kyma-bot