Prevent incompatible migration of Shoot to Runtime CR #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
kyma-bot
added
size/XL
…nto migration-fuse
kyma-bot
removed
the
do-not-merge/work-in-progress
mvshao
force-pushed
the
migration-fuse
branch
from
7288158
to
1832682
Compare
mvshao
force-pushed
the
migration-fuse
branch
from
f47a937
to
61f81f7
Compare
VOID404
previously approved these changes
Oct 16, 2024
Comment on lines
+27
to
+32
| equal := len(differences) == 0 | ||
|
|
||
| return Result{ | ||
| Equal: equal, | ||
| Diff: differences, | ||
| }, nil |
There was a problem hiding this comment.
equal could be a method that returns len(this.differences) == 0, but this is fine too, although easier to break
|
|
||
| if !equal { | ||
| diff := Difference{ | ||
| ShootName: leftShoot.Name, // assumption that leftShoot and rightShoot have the same name |
There was a problem hiding this comment.
should that assumption be checked? If this is supposed to be always true, maybe it's safer to even crash if it ever isn't?
There was a problem hiding this comment.
Thx, I will add the step with checking if left == right
VOID404
added
the
do-not-merge/hold
VOID404
approved these changes
Oct 16, 2024
mvshao
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
runtime-migratorto abandon migration of existing Shoot if the generated shoot based on runtime CR will differ from the one on the clusterRelated issue(s)
#400