Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShootAndSeedSameRegion - Schema & Feature Flag #796

Merged
merged 8 commits into from
Jun 5, 2024
Merged

ShootAndSeedSameRegion - Schema & Feature Flag #796

merged 8 commits into from
Jun 5, 2024

Conversation

ralikio
Copy link
Member

@ralikio ralikio commented Jun 4, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • new parameter shootAndSeedSameRegion added to the KEB schema,
  • feature flag to disable rendering of the parameter.

Related issue(s)

@ralikio ralikio requested a review from a team as a code owner June 4, 2024 13:37
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 4, 2024
@ralikio ralikio added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Jun 4, 2024
@ralikio ralikio changed the title Schema & Feature Flag ShootAndSeedSameRegion - Schema & Feature Flag Jun 5, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 5, 2024
@kyma-bot kyma-bot merged commit f869a28 into kyma-project:main Jun 5, 2024
24 of 25 checks passed
This was referenced Jun 5, 2024
Closed
Open
@ralikio ralikio added kind/feature Categorizes issue or PR as related to a new feature. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature and removed kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature kind/feature Categorizes issue or PR as related to a new feature. labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralikio @jaroslaw-pieszka @kyma-bot