Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIRule v1alpha1 removal #18152

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Conversation

strekm
Copy link
Contributor

@strekm strekm commented Sep 12, 2023

Description

Changes proposed in this pull request:

  • APIRule v1alpha1 removal

Related issue(s)

@strekm strekm added the area/api-gateway Issues or PRs related to api-gateway label Sep 12, 2023
@strekm strekm added this to the 2.19 milestone Sep 12, 2023
@strekm strekm requested a review from a team as a code owner September 12, 2023 09:16
@netlify
Copy link

netlify bot commented Sep 12, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4590712

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 4590712
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/650ad7a9aae94500088dde9d
😎 Deploy Preview https://deploy-preview-18152--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 12, 2023
@barchw
Copy link
Contributor

barchw commented Sep 12, 2023

/test all

@barchw
Copy link
Contributor

barchw commented Sep 12, 2023

Looks like we need to update the configuration in API Gateway controller, as it mounts the certificate as volume: https://github.com/kyma-project/api-gateway/blob/34ad0e736e8b413a5861e75a11e472ec13ba6fe5/main.go#L154C4-L154C4

@strekm strekm added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2023
@barchw barchw requested review from a team as code owners September 20, 2023 11:29
@barchw barchw requested a review from muralov September 20, 2023 11:29
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 21, 2023
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2023
@muralov muralov added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 21, 2023
@muralov
Copy link
Contributor

muralov commented Sep 22, 2023

/retest

@muralov
Copy link
Contributor

muralov commented Sep 22, 2023

/test pre-main-kyma-gardener-gcp-eventing

@muralov
Copy link
Contributor

muralov commented Sep 22, 2023

/test pre-main-kyma-gardener-gcp-eventing-upgrade

@kyma-bot kyma-bot merged commit 893751b into kyma-project:main Sep 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api-gateway Issues or PRs related to api-gateway lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants