Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up defaulting webhook code #18164

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Sep 14, 2023

Description

Changes proposed in this pull request:

  • add test for effectiveResource
  • remove not needed defaulting config

Related issue(s)
kyma-project/serverless#248

@netlify
Copy link

netlify bot commented Sep 14, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3e1ce58

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2023
@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 3e1ce58
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/650c03f83fbf670008667de8
😎 Deploy Preview https://deploy-preview-18164--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 14, 2023
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dbadura
Copy link
Contributor Author

dbadura commented Sep 14, 2023

/test all

@dbadura
Copy link
Contributor Author

dbadura commented Sep 20, 2023

/test all

@dbadura dbadura marked this pull request as ready for review September 20, 2023 08:49
@dbadura dbadura requested a review from a team as a code owner September 20, 2023 08:49
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2023
@pPrecel pPrecel self-assigned this Sep 21, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 21, 2023
@kyma-bot kyma-bot merged commit 354ba85 into kyma-project:main Sep 21, 2023
4 checks passed
@dbadura dbadura deleted the remove-defaulting-webhook branch September 21, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants