Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Telemetry component #18194

Merged
merged 13 commits into from
Sep 22, 2023
Merged

Remove Telemetry component #18194

merged 13 commits into from
Sep 22, 2023

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Sep 19, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • fast-integration tests:
    • Remove telemetry tests
    • Remove logging tests
    • Remove eventing tests which depend on tracing
  • Remove telemetry resources
  • Remove the following CRDs: LogParsers, LogPipelines, TracePipelines
  • Remove the telemetry component entry from the components list

Related issue(s)

#18190

@shorim shorim added area/logging Issues or PRs related to the logging module (deprecated) do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/telemetry Issues or PRs related to the telemetry module labels Sep 19, 2023
@shorim shorim requested review from a team as code owners September 19, 2023 22:19
@netlify
Copy link

netlify bot commented Sep 19, 2023 •
edited
Loading

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4515dfa

@netlify
Copy link

netlify bot commented Sep 19, 2023 •
edited
Loading

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 4515dfa
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/650c54f94542e10008cd2464
😎 Deploy Preview https://deploy-preview-18194--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 19, 2023
@shorim
Copy link
Contributor Author

shorim commented Sep 19, 2023

/test pre-main-kyma-integration-k3d

1 similar comment
@shorim
Copy link
Contributor Author

shorim commented Sep 19, 2023

/test pre-main-kyma-integration-k3d

@shorim shorim requested a review from a team as a code owner September 20, 2023 12:10
@shorim shorim changed the title Remove telemetry fast integration tests Remove Telemetry component Sep 20, 2023
@shorim shorim removed the area/logging Issues or PRs related to the logging module (deprecated) label Sep 21, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Sep 21, 2023 •
edited
Loading

@shorim: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-integration-k3d-telemetry 4515dfa link true /test pre-main-kyma-integration-k3d-telemetry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shorim
Copy link
Contributor Author

shorim commented Sep 21, 2023

/retest

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 21, 2023
@shorim shorim modified the milestones: 2.18.1, 2.19 Sep 21, 2023
@shorim shorim removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2023
@kyma-bot kyma-bot merged commit c5cc5f0 into kyma-project:main Sep 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muralov muralov muralov approved these changes

@a-thaler a-thaler a-thaler approved these changes

@ruanxin ruanxin ruanxin approved these changes

@chrkl chrkl chrkl approved these changes

@marcobebway marcobebway Awaiting requested review from marcobebway marcobebway was automatically assigned from kyma-project/eventing

Assignees

@chrkl chrkl

@ruanxin ruanxin

@a-thaler a-thaler

@muralov muralov

Labels
area/telemetry Issues or PRs related to the telemetry module kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
2.19
Development

Successfully merging this pull request may close these issues.
6 participants
@shorim @kyma-bot @chrkl @ruanxin @a-thaler @muralov