Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove v3alpha1 test, relocate moduletemplate #2030

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

chore: Remove v3alpha1 test, relocate moduletemplate #2030

wants to merge 12 commits into from

Conversation

ruanxin
Copy link
Contributor

@ruanxin ruanxin commented Nov 14, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Remove v3alpha1 ocm schema test, we are not officially use this schema version
  • Relocate integration test related moduletemplate into different folder
  • Replaced outdated moduletempate(operator_v1beta2_moduletemplate_kcp-module.yaml) for integration test
  • Make kyma, moduletemplate deployed in correct kcp-system namespace for integration test

Related issue(s)

@ruanxin ruanxin requested a review from a team as a code owner November 14, 2024 21:49
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 14, 2024
@ruanxin
use up to date moduletemplate.go v1beta2_template_operator_current_oc…
6b28ddc 
…m.yaml for integration test, replace outdated operator_v1beta2_moduletemplate_kcp-module.yaml
@ruanxin
make kyma, moduletemplate deployed in correct kcp-system namespace fo…
bad8af6 
…r integration test
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2024
@ruanxin ruanxin requested a review from a team as a code owner November 15, 2024 20:58
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 15, 2024
@lindnerby lindnerby self-assigned this Nov 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitoraj mmitoraj mmitoraj approved these changes

@lindnerby lindnerby Awaiting requested review from lindnerby

At least 1 approving review is required to merge this pull request.

Assignees

@mmitoraj mmitoraj

@lindnerby lindnerby

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruanxin @mmitoraj @kyma-bot @lindnerby