feat: Kyma stats receiver #45
Conversation
hisarbalik
added
do-not-merge/hold
Co-authored-by: Nina Hingerl <[email protected]>
…try-collector-components into kymastats-receiver
…try-collector-components into kymastats-receiver
|
/hold |
kyma-bot
added
the
do-not-merge/hold
hisarbalik
removed
the
do-not-merge/hold
| return nil, &fieldNotFoundError{"state"} | ||
| } | ||
|
|
||
| unstructuredConds, found, err := unstructured.NestedSlice(status, "conditions") |
There was a problem hiding this comment.
are conditions really mandatory (included in the kyma module contract)?
There was a problem hiding this comment.
There is no kyma module contract about the status conditions
There was a problem hiding this comment.
And with that they are not mandatory
| return nil, errors.New("condition is not a map") | ||
| } | ||
|
|
||
| condType, found, err := unstructured.NestedString(condMap, "type") |
There was a problem hiding this comment.
all the following code is based on the expectation that the conditions implement fields similar to metav1.conditions. This is not mandatory. We should not fail if a module either does not implement conditions at all, or if those conditions do not follow the same patterns as metav1.conditions (even though it is recommended that conditions are based on metav1)
Here are all requirements that i could find: https://github.com/kyma-project/template-operator?tab=readme-ov-file#api-definition-steps
There was a problem hiding this comment.
We assume that the CR has metav1.condition implementation. When a CR has no metav1.condition implementation is not scrapeable
There was a problem hiding this comment.
so in the end, even though there is no real contract (and it would be quite simple for us to exclude the conditions for such modules) we just fail with scraping for those modules?
There was a problem hiding this comment.
In case a module doe not have conditions or is not following the conventions, we should just skip that part, the same way as we skip when we cannot find a resource for a module CRD
Description
Changes proposed in this pull request (what was done and why):
kymastatsreceiverTelemetrymodule status, and emit two metricskyma.module.status.conditionsandkyma.module.status.stateChanges refer to particular issues, PRs or documents:
Traceability
areaandkindlabel.Related Issuessection.