Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Separate RBAC declarations by component for clearer access requirements #1606

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: Separate RBAC declarations by component for clearer access requirements #1606

wants to merge 5 commits into from

Conversation

jeffreylimnardy
Copy link
Contributor

@jeffreylimnardy jeffreylimnardy commented Nov 12, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Separate RBACs to be component-based for otelcollector components

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@jeffreylimnardy jeffreylimnardy added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/chore Categorizes issue or PR as related to a chore. area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline labels Nov 12, 2024
@jeffreylimnardy jeffreylimnardy requested a review from a team as a code owner November 12, 2024 13:56
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2024
@jeffreylimnardy jeffreylimnardy added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 12, 2024
@jeffreylimnardy jeffreylimnardy removed the area/logs LogPipeline label Nov 12, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 12, 2024
@jeffreylimnardy jeffreylimnardy removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@k15r k15r

Labels
area/metrics MetricPipeline area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffreylimnardy @k15r @kyma-bot