Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button for Hacker News #132

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add button for Hacker News #132

wants to merge 2 commits into from

Conversation

Abd-Elhadi
Copy link

Fixes #130

kytta
kytta requested changes Sep 18, 2024
View reviewed changes
Copy link
Owner

@kytta kytta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and thanks for the contribution! I have some smaller edit wishes, especially the icon is critical.

src/icons/hackernews.svg Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
src/shareon.css Show resolved Hide resolved
src/shareon.js Outdated Show resolved Hide resolved
@kytta kytta changed the title Added Hackernews sharing option #130 Add button for Hacker News Sep 18, 2024
@kytta kytta added the new button Issues that request or PRs that add new social buttons label Sep 18, 2024
kytta
kytta requested changes Sep 18, 2024
View reviewed changes
Copy link
Owner

@kytta kytta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, another thing that caught my eye and that would be nice to fix

src/shareon.css Outdated Show resolved Hide resolved
@Abd-Elhadi
Copy link
Author

Hi @kytta

I've made the requested changes:

  • Updated the Y Combinator icon with the official version from Simple Icons and ensured it's monochrome white.
  • Reorganized the Hacker News button, styles, and function in alphabetical order as per your suggestion.

Let me know if there’s anything else to tweak!

Thanks again for your feedback ✌🏻

kytta
kytta reviewed Sep 23, 2024
View reviewed changes
Copy link
Owner

@kytta kytta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Looks good so far. I'll test this locally and will let you know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kytta kytta kytta requested changes

Assignees
No one assigned
Labels
new button Issues that request or PRs that add new social buttons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Hacker News button
2 participants
@Abd-Elhadi @kytta