Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block number indexer #10

Merged
merged 10 commits into from
Sep 15, 2023
Merged

Block number indexer #10

merged 10 commits into from
Sep 15, 2023

Conversation

sdlyy
Copy link
Member

@sdlyy sdlyy commented Sep 14, 2023

Resolves L2B-2153

@vercel
Copy link

vercel bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lz-monitoring-frontend ✅ Ready (Inspect) Visit Preview Sep 15, 2023 9:53am

@sdlyy sdlyy marked this pull request as ready for review September 15, 2023 07:55
@sdlyy sdlyy self-assigned this Sep 15, 2023
Copy link
Contributor

@michalsidzej michalsidzej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please align the BlockNumberIndexer example in the @l2beat/uif after merging this package. You can even copy the tests there.

@linear
Copy link

linear bot commented Sep 15, 2023

L2B-2153 Set up BlockNumberIndexer

The BlockNumberIndexer gets the latest block number. The source for block numbers would be block explorer (Etherscan) and RPC endpoint.

Ideally, we'll copy the code from dydx for this indexer and adapt it.

  • Should be a child of RootIndexer

Part of this work was done while writing examples to UIF. This example can be used as a reference: https://linear.app/l2beat/issue/L2B-1818/write-a-latest-block-indexer-based-on-dydx-work

@sdlyy sdlyy merged commit 920dc67 into main Sep 15, 2023
5 checks passed
@sdlyy sdlyy deleted the block-number-indexer branch September 15, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants