Add discovery repository #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sdlyy
approved these changes
Sep 14, 2023
| @@ -11,8 +11,14 @@ declare module 'knex/types/tables' { | |||
| last_updated: Date | |||
| } | |||
|
|
|||
| interface DiscoveryRow { | |||
| one_row_id: true | |||
There was a problem hiding this comment.
This is a trick that makes sure we store only one row in this table.
|
|
||
| function toRecord(row: DiscoveryRow): DiscoveryRecord { | ||
| return { | ||
| discoveryOutput: row.discovery_json_blob as unknown as DiscoveryOutput, |
There was a problem hiding this comment.
Maybe we should consider schema validation in the future ❔
There was a problem hiding this comment.
I think this is not necessary, as only this repository will write to this table. I think that we could be storing individual values in the future (maybe). I agree that this is something we should think about.
michalsidzej
force-pushed
the
feat/discovery-repository
branch
from
270dc24
to
40b413b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves L2B-2261