Deprecate ctMock.add() #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move away from console.warn and instead use the official api
The `ctMock.add()` function directly insert objects in the in-memory store of commercetools mock, which could result in invalid objects being processed
🦋 Changeset detectedLatest commit: 0c33913 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ctMock.add()function directly inserts objects in the in-memory store of commercetools mock, which could result in invalid objects being processed due to missing validation, or pre processing hooks.This change introduces a new method
unsafeAdd()to still have this option available while clearly signalling you shouldn't normally use it.Note that this for now only shows a deprecation warning, the functionality will still be there for the foreseeable future