Exporter: always use tcp for ser2net #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn the version variable into a tuple which consists of (major, minor, micro). Convert the exit code check to use tuples instead of strings and also correct the version check for the YAML configuration to use a tuple. No functional changes intended. Signed-off-by: Rouven Czerwinski <[email protected]>
Contrary to the code, ser2net started using the YAML configuration in version 4.2.0, correct the exporter version check. Signed-off-by: Rouven Czerwinski <[email protected]>
Always indicate that the network connection should use tcp. This was not mandatory for versions before 4.6.0, but is for versions afterwards. This should not impact the behavior for earlier versions, since all versions since the introduction of YAML configurations in 4.2.0 support this parameter. Fixes labgrid-project#1416 Signed-off-by: Rouven Czerwinski <[email protected]>
Emantor
force-pushed
the
topic/ser2net-tcp
branch
from
7026258
to
a3dbfb5
Compare
jluebbe
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the ser2net version check and support ser2net >=4.6.0.
Checklist
Fixes #1416