driver/power/tplink: use IotStrip instead of deprecated SmartStrip #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bastian-Krause
added
the
dependencies
This allows us to use a newly introduced and not deprecated replacement for the kasa.SmartStrip class. Signed-off-by: Bastian Krause <[email protected]>
Since python-kasa 0.7.0, the SmartStrip class is deprecated [1]. The docs state [2]: "If you want to continue to use the old API for older devices, you can use the classes in the iot module to avoid deprecation warnings." Do that. [1] https://python-kasa.readthedocs.io/en/stable/smartstrip.html [2] https://python-kasa.readthedocs.io/en/stable/deprecated.html#deprecated-api-reference Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
force-pushed
the
bst/kasa-0.7.0
branch
from
82a7de6
to
15dfb31
Compare
|
@CardboardTurkey You contributed the original code. Could you take a look at this? |
|
This looks reasonable! I'm afraid I no longer have access to the hardware required to test these changes though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a draft because python-kase 0.7.0 requires Python >=3.9, labgrid still supports Python 3.8.
Increase the minimum python-kasa version to 0.7.0. This allows us to use a newly introduced and not deprecated replacement for the kasa.SmartStrip class.
Since python-kasa 0.7.0, the SmartStrip class is deprecated.
The docs state:
"If you want to continue to use the old API for older devices, you can use the classes in the iot module to avoid deprecation warnings."
https://python-kasa.readthedocs.io/en/stable/deprecated.html#deprecated-api-reference
Do that.
Checklist