refactor: Remove the foreign key constraint of vfolders.{user,group} #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
comp:manager
4 tasks
15 tasks
achimnol
added
type:refactor
achimnol
force-pushed
the
topic/remove-users-vfolders-freignkey
branch
from
ed27ce0
to
0c35a76
Compare
fregataa
reviewed
Jul 9, 2024
Comment on lines
+28
to
+38
| op.create_check_constraint( | ||
| "ck_vfolders_ownership_type_match_with_user_or_group", | ||
| "vfolders", | ||
| "(ownership_type = 'user' AND \"user\" IS NOT NULL) OR " | ||
| "(ownership_type = 'group' AND \"group\" IS NOT NULL)", | ||
| ) | ||
| op.create_check_constraint( | ||
| "ck_vfolders_either_one_of_user_or_group", | ||
| "vfolders", | ||
| '("user" IS NULL AND "group" IS NOT NULL) OR ("user" IS NOT NULL AND "group" IS NULL)', | ||
| ) |
There was a problem hiding this comment.
How should we handle integrity errors which can occur if some vfolder records have null values for both user and group columns?
There was a problem hiding this comment.
We discussed about this issue and we will cover it by introducing placeholder user (a.k.a ghost user)
fregataa
approved these changes
Jul 9, 2024
2 tasks
Merge activity
|
achimnol
force-pushed
the
topic/remove-users-vfolders-freignkey
branch
from
53f34cb
to
82b47f2
Compare
lablup-octodog
pushed a commit
that referenced
this pull request
Jul 9, 2024
…2404) refs #2376 Remove the foreign/check constraints preventing decoupling of user/vfolder deletions. **Checklist:** (if applicable) - [x] Milestone metadata specifying the target backport version - [x] Mention to the original issue Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 2404
4 tasks
lablup-octodog
added a commit
that referenced
this pull request
Jul 13, 2024
…2404) (#2406) refs #2376 Co-authored-by: achimnol <[email protected]> Remove the foreign/check constraints preventing decoupling of user/vfolder deletions. Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 2404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #2376
Remove the foreign/check constraints preventing decoupling of user/vfolder deletions.
Checklist: (if applicable)