Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enable_LLM_playground config on webserver #2677

Merged

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Aug 8, 2024

related PR: https://app.graphite.dev/github/pr/lablup/backend.ai-webui/2620

TL;DR

Enable/disable the LLM Playground tab in the service page via the new enable_LLM_playground configuration option.

What changed?

  • Added enable_LLM_playground option to sample.conf.
  • Updated config.py to process the new option.
  • Modified config.toml.j2 and config_ini.toml.j2 templates to incorporate the new option.

How to test?

  1. Go to configs/webserver/sample.conf and set enable_LLM_playground to true or false.
  2. Restart the webserver.
  3. Verify that the LLM Playground tab appears or disappears in the service page based on the configuration.

Why make this change?

The change introduces a flexible way to enable or disable the LLM Playground tab in the service page, providing better control over the web server's UI configuration.


Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@github-actions github-actions bot added comp:webserver Related to Web Server component size:XS ~10 LoC labels Aug 8, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

@agatha197 agatha197 force-pushed the feature/add-enable_LLM_playground-config-on-webserver branch from faee0af to 610f73d Compare August 8, 2024 07:57
@agatha197 agatha197 marked this pull request as ready for review August 8, 2024 07:57
@kyujin-cho kyujin-cho added this to the 24.03 milestone Aug 9, 2024
@kyujin-cho kyujin-cho added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit 60fda92 Aug 9, 2024
18 checks passed
@kyujin-cho kyujin-cho deleted the feature/add-enable_LLM_playground-config-on-webserver branch August 9, 2024 14:23
lablup-octodog pushed a commit that referenced this pull request Aug 9, 2024
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2677
github-merge-queue bot pushed a commit that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:webserver Related to Web Server component size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants