-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change vfolder name when deleted to allow reusing the name #3061
Merged
achimnol
merged 7 commits into
main
from
topic/11-09-fix_update_vfolder_name_before_delete-forever
Nov 12, 2024
Merged
fix: Change vfolder name when deleted to allow reusing the name #3061
achimnol
merged 7 commits into
main
from
topic/11-09-fix_update_vfolder_name_before_delete-forever
Nov 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
comp:manager
Related to Manager component
size:S
10~30 LoC
labels
Nov 9, 2024
This was referenced Nov 9, 2024
achimnol
approved these changes
Nov 12, 2024
I didn't mean to include extra alphabets like "H", "M", "S" here. Sorry for presenting a wrong example in the chat!
achimnol
changed the title
fix: Update vfolder name before delete-forever
fix: Change vfolder name when deleted to allow reusing the name
Nov 12, 2024
achimnol
deleted the
topic/11-09-fix_update_vfolder_name_before_delete-forever
branch
November 12, 2024 00:31
lablup-octodog
pushed a commit
that referenced
this pull request
Nov 12, 2024
Co-authored-by: Joongi Kim <[email protected]> Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 3061
lablup-octodog
pushed a commit
that referenced
this pull request
Nov 12, 2024
Co-authored-by: Joongi Kim <[email protected]> Backported-from: main (24.12) Backported-to: 24.03 Backport-of: 3061
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
… (#3073) Co-authored-by: Sanghun Lee <[email protected]> Co-authored-by: Joongi Kim <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
… (#3074) Co-authored-by: Sanghun Lee <[email protected]> Co-authored-by: Joongi Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3041
Update vfolder name before delete-forever.
The deletion date time format is
%Y-%m-%dT%HH%MM%SS%z
, update the name to{ORIGINAL}_deleted_{DATE-TIME}
.Checklist: (if applicable)
ai.backend.test