Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change vfolder name when deleted to allow reusing the name #3061

Merged

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Nov 9, 2024

resolves #3041

Update vfolder name before delete-forever.
The deletion date time format is %Y-%m-%dT%HH%MM%SS%z, update the name to {ORIGINAL}_deleted_{DATE-TIME}.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Update of end-to-end CLI integration tests in ai.backend.test

Copy link
Member Author

fregataa commented Nov 9, 2024

@fregataa fregataa marked this pull request as ready for review November 10, 2024 04:48
I didn't mean to include extra alphabets like "H", "M", "S" here.
Sorry for presenting a wrong example in the chat!
@achimnol achimnol changed the title fix: Update vfolder name before delete-forever fix: Change vfolder name when deleted to allow reusing the name Nov 12, 2024
@achimnol achimnol added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit bc8eaa1 Nov 12, 2024
24 of 25 checks passed
@achimnol achimnol deleted the topic/11-09-fix_update_vfolder_name_before_delete-forever branch November 12, 2024 00:31
lablup-octodog pushed a commit that referenced this pull request Nov 12, 2024
Co-authored-by: Joongi Kim <[email protected]>
Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 3061
lablup-octodog pushed a commit that referenced this pull request Nov 12, 2024
Co-authored-by: Joongi Kim <[email protected]>
Backported-from: main (24.12)
Backported-to: 24.03
Backport-of: 3061
github-merge-queue bot pushed a commit that referenced this pull request Nov 12, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update vfolder name before "delete-forever"
2 participants