Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circuit #5

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Circuit #5

wants to merge 11 commits into from

Conversation

JohnDoePlusPlus
Copy link

No description provided.

dimadeveatii
dimadeveatii requested changes Nov 14, 2019
View reviewed changes
Copy link
Member

@dimadeveatii dimadeveatii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the implementation. Please cover also with unit tests each file.

lib/circuit/CircuitOptions.ts Outdated Show resolved Hide resolved
lib/utils/isPromiseLike.ts Outdated Show resolved Hide resolved
lib/circuit/factories/circuitStateStorageFactory.ts Outdated Show resolved Hide resolved
lib/circuit/factories/circuitStateFactory.ts Outdated Show resolved Hide resolved
lib/circuit/CircuitState/CircuitState.ts Outdated Show resolved Hide resolved
lib/circuit/CircuitState/CircuitState.ts Outdated Show resolved Hide resolved
@JohnDoePlusPlus
circuit
77685cd 
implement factories as class (not function)
move each factory to its entity folde
change isPromise function
@JohnDoePlusPlus
circuit
d1701c5 
add tests for CircuitState and its factory
and tests for Policies and their factory
dimadeveatii
dimadeveatii requested changes Nov 15, 2019
View reviewed changes
lib/circuit/CircuitState/factory.ts Outdated Show resolved Hide resolved
lib/circuit/CircuitStateStorage/ArgumentsCircuitStateStorage.ts Outdated Show resolved Hide resolved
lib/circuit/CircuitStateStorage/ArgumentsCircuitStateStorage.ts Show resolved Hide resolved
lib/circuit/CircuitStateStorage/factory.ts Outdated Show resolved Hide resolved
lib/circuit/CircuitState/CircuitState.ts Outdated Show resolved Hide resolved
lib/circuit/CircuitState/CircuitState.ts Outdated Show resolved Hide resolved
lib/circuit/Policy/factory.ts Outdated Show resolved Hide resolved
lib/utils/isPromise.ts Outdated Show resolved Hide resolved
@JohnDoePlusPlus
circuit
a1c0dfe 
change isPromise to isPromiseLike
add more tests
remove from factories one line functions
add spies
@JohnDoePlusPlus
circuit
b92ab5c 
rename policy methods
CircuitState separate code in methods
@JohnDoePlusPlus
circuit
d849b48 
CircuitState separate code in methods
and rename removeExecution method to registerCall
@JohnDoePlusPlus
Merge branch 'feature/circuit' of github.com:JohnDoePlusPlus/micro-de…
181899b 
…corators into feature/circuit
@JohnDoePlusPlus
circuit
7b6d482 
add unit test (now everything is tested)
change implementation of CircuitState and ArgumentsCircuitStateStorage
to avoid memory leaks
@JohnDoePlusPlus
circuit
3f007a8 
improve unit tests
JohnDoePlusPlus and others added 2 commits November 22, 2019 19:03
@JohnDoePlusPlus
circuit
6b6644e 
improve tests
@JohnDoePlusPlus
circuit
049174c 
improve all factories
adjust unit tests for factories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimadeveatii dimadeveatii Awaiting requested review from dimadeveatii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnDoePlusPlus @dimadeveatii