Fix flushing in Gzip middleware #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1317 +/- ##
==========================================
+ Coverage 84.27% 84.38% +0.11%
==========================================
Files 27 27
Lines 1990 1992 +2
==========================================
+ Hits 1677 1681 +4
+ Misses 205 203 -2
Partials 108 108
Continue to review full report at Codecov.
|
This was referenced Apr 9, 2019
|
@htdvisser thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request makes the
Flush()method of response writer in the Gzip middleware callFlushon the underlying response writer, instead of only on the gzip writer.I also added an extra test case that asserts that the headers and first bytes are written and flushed after
Flush()is called for the first time.