fix(lwlogger): do not override explicit level argument (#1084)

lacework · Dec 28, 2022 · 452dff8 · 452dff8
1 parent c5a04ea
commit 452dff8
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/lwlogger/logger.go b/lwlogger/logger.go
@@ -51,9 +51,8 @@ var (
 
 // New initialize a new logger with the provided level and options
 func New(level string, options ...zap.Option) *zap.Logger {
-	// give priority to the environment variable
-	if envLevel := LogLevelFromEnvironment(); envLevel != "" {
-		level = envLevel
+	if level == "" {
+		level = LogLevelFromEnvironment()
 	}
 
 	zapConfig := zap.Config{
@@ -81,9 +80,8 @@ func New(level string, options ...zap.Option) *zap.Logger {
 // NewWithWriter initialize a new logger with the provided level and options
 // but redirecting the logs to the provider io.Writer
 func NewWithWriter(level string, out io.Writer, options ...zap.Option) *zap.Logger {
-	// give priority to the environment variable
-	if envLevel := LogLevelFromEnvironment(); envLevel != "" {
-		level = envLevel
+	if level == "" {
+		level = LogLevelFromEnvironment()
 	}
 
 	var (