feat(cdk): improve honeyvent data for components #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
force-pushed
the
afiune/cdk/honeycomb
branch
from
fa1d3d4
to
8894505
Compare
afiune
requested review from
slshen and
hazedav
and removed request for
slshen
Signed-off-by: Salim Afiune Maya <[email protected]>
Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
commented
Nov 10, 2022
| @@ -297,6 +297,9 @@ open_pull_request() { | |||
| curl -XPOST -H "Authorization: token $GITHUB_TOKEN" --data "@$_body" \ | |||
| https://api.github.com/repos/${org_name}/${project_name}/pulls > $_pr | |||
|
|
|||
| # @afiune just to debug the issue where the field `html_url` comes as `null` | |||
| echo "$_pr" | jq . | |||
There was a problem hiding this comment.
We are having issues with our release pipeline, look at https://g.codefresh.io/build/636d470f5cb99a96099d1eaf?step=TriggerRelease&tab=output&logs=terminal
Output:
--> go-sdk: opening GH pull request
--> go-sdk:
--> go-sdk: It is time to review the release!
--> go-sdk: null
afiune
commented
Nov 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves how we send a Honeyvent for components, this change also moves the logic of
parsing flags and initializing CLI state to the
PersistentPreRunE()func.How did you test this change?
I will add a number of integrations tests but first I want to check if this logic looks good or not?
Issue
N/A