Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gcp sidekick integration server token #1054

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

ammarekbote
Copy link
Contributor

Summary

Expose server token for GcpSidekick integration

How did you test this change?

Modified test to check for server token and ran make test to verify the test still passes.
Imported the code in terraform-module and verified we see the server_token there.

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Outputs:

bucket_name = "storage bucket id"
client_email = "[email protected]"
client_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
name = "GCP Agentless Scanning Example"
scan_frequency = 24
scanning_project_id = "gcp-lw-scanner"
server_token = "_xyzdefasasas"

Issue

@dmurray-lacework
Copy link
Collaborator

@ammarekbote think we just need to rebase and sign commits on this before merging.

@ammarekbote ammarekbote force-pushed the GcpSidekickIntegration-ServerToken branch from 74435d0 to 1c05663 Compare December 7, 2022 13:15
@ammarekbote ammarekbote merged commit 6a16fdf into main Dec 7, 2022
@ammarekbote ammarekbote deleted the GcpSidekickIntegration-ServerToken branch December 7, 2022 14:41
@lacework-releng lacework-releng mentioned this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants