Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add AWS S3 alert channel integration #273

Merged
merged 7 commits into from
Dec 28, 2020
Merged

feat: add AWS S3 alert channel integration #273

merged 7 commits into from
Dec 28, 2020

Conversation

dmurray-lacework
Copy link
Collaborator

Aws S3 alert channel

Signed-off-by: Darren Murray [email protected]

@afiune afiune self-assigned this Dec 21, 2020
@afiune afiune added api Something related to the Go API client cli Something related to the Lacework CLI feat New feature or request labels Dec 21, 2020
afiune
afiune suggested changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One major change about the CLI create integration command, the rest are nitpicks!

api/integration_alert_channels_aws_s3.go Outdated Show resolved Hide resolved
cli/cmd/integration_aws_s3_channel.go Outdated Show resolved Hide resolved
api/integration_alert_channels_aws_s3.go Outdated
return
}

// UpdateAwsS3AlertChannel updates a single awsS3 alert channel integration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/awsS3/AWS_S3

api/integration_alert_channels_aws_s3.go Outdated Show resolved Hide resolved
api/integration_alert_channels_aws_s3.go Outdated Show resolved Hide resolved
afiune
afiune approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-197532084

@afiune afiune changed the title feat(cli): Add Aws S3 alert channel feat: add AWS S3 alert channel integration Dec 28, 2020
@afiune afiune merged commit 383de18 into master Dec 28, 2020
@afiune afiune deleted the dmurray-lacework/alert-s3 branch December 28, 2020 08:26
@afiune afiune mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afiune afiune afiune approved these changes

@scottford-lw scottford-lw Awaiting requested review from scottford-lw

Assignees

@afiune afiune

Labels
api Something related to the Go API client cli Something related to the Lacework CLI feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmurray-lacework @afiune