feat(cli): support manifest bigger than 1k packages #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**User Story** As a user of the Lacework CLI, I would like to be able to submit scans of package manifests bigger than 1,000 packages, So I don't have to implement a splitting mechanism and run multiple CLI commands for a single manifest. **Implementation Details** The CLI will now check if the package manifest has more than the maximum number of packages, if so, it will split the package manifest into multiple chunks and trigger multiple API requests. **NOTE:** We disallow more than 10 parallel requests (workers), which are more than 10,000 packages on a single manifest/system. Closes #237 Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
added
feat
dmurray-lacework
approved these changes
Jan 7, 2021
Signed-off-by: Salim Afiune Maya <[email protected]>
Added new feature
|
scottford-lw
approved these changes
Jan 7, 2021
Signed-off-by: Salim Afiune Maya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Story
As a user of the Lacework CLI,
I would like to be able to submit scans of package manifests bigger than 1,000 packages,
So I don't have to implement a splitting mechanism and run multiple CLI commands for a single manifest.
Implementation Details
The CLI will now check if the package manifest has more than the maximum
number of packages, if so, it will split the package manifest into
multiple chunks and trigger multiple API requests.
NOTE: We disallow more than 10 parallel requests (workers), which
are more than 10,000 packages on a single manifest/system.
Closes #237
JIRA: ALLY-275
Signed-off-by: Salim Afiune Maya [email protected]