Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): implement account information endpoint #349

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

afiune
Copy link
Contributor

@afiune afiune commented Mar 22, 2021

As a Lacework Engineer that needs to migrate tools and integrations from APIv1 to APIv2,

I need to have a mechanism to identify both authentication methods,
So that I can start using both API versions and migrate endpoints gradually (not all at once).

JIRA ALLY-369

Signed-off-by: Salim Afiune Maya [email protected]

As a Lacework Engineer that needs to migrate tools and
integrations from APIv1 to APIv2,
I need to have a
mechanism to identify both authentication methods,
So that I can start using both API versions and migrate
endpoints gradually (not all at once).

JIRA ALLY-369

Signed-off-by: Salim Afiune Maya <[email protected]>
@afiune afiune self-assigned this Mar 22, 2021
@afiune afiune added feat New feature or request api Something related to the Go API client labels Mar 22, 2021
Copy link
Contributor

@scottford-lw scottford-lw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

api/account.go Outdated
client *Client
}

func (svc *AccountService) OrganizationInfo() (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every function inside the Go-Client has to have an action, this was missing:

Suggested change
func (svc *AccountService) OrganizationInfo() (
func (svc *AccountService) GetOrganizationInfo() (

@afiune afiune merged commit 1392ecb into main Mar 23, 2021
@afiune afiune deleted the afiune/ALLY-369/orgInfo branch March 23, 2021 00:29
This was referenced Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Something related to the Go API client feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants