feat: AWS GovCloud Config integration #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darren Murray <[email protected]>
afiune
reviewed
May 21, 2021
afiune
changed the title
Co-authored-by: Salim Afiune <[email protected]>
Co-authored-by: Salim Afiune <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
afiune
reviewed
May 25, 2021
afiune
reviewed
May 25, 2021
Signed-off-by: Darren Murray <[email protected]>
…dCreds to pointers Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
afiune
approved these changes
May 25, 2021
Signed-off-by: Darren Murray <[email protected]>
afiune
reviewed
May 26, 2021
afiune
reviewed
May 26, 2021
afiune
reviewed
May 26, 2021
afiune
reviewed
May 26, 2021
afiune
reviewed
May 26, 2021
| assert.Equal(t, 1, data.Enabled, "a new GCP integration should be enabled") | ||
| assert.Equal(t, "integration_name", data.Name, "AWS integration name mismatch") | ||
| assert.Equal(t, "AWS_CT_SQS", data.Type, "a new AWS integration should match its type") | ||
| assert.Equal(t, 1, data.Enabled, "a new AWS integration should be enabled") |
afiune
reviewed
May 26, 2021
cli/cmd/integration.go
Outdated
| case "AWS GovCloud Config": | ||
| return createAwsGovCloudConfigIntegration() | ||
| case "AWS GovCloud CloudTrail": | ||
| return createAwsGovCloudCTIntegration() |
There was a problem hiding this comment.
nit: If we change the Integration type, would be nice to change these functions too
Suggested change
| return createAwsGovCloudCTIntegration() | |
| return createAwsGovCloudCloudTrailIntegration() |
Co-authored-by: Salim Afiune <[email protected]>
Co-authored-by: Salim Afiune <[email protected]>
Co-authored-by: Salim Afiune <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS Gov Cloud Config integration
Signed-off-by: Darren Murray [email protected]