Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): LQLv2 support #441

Merged
merged 4 commits into from
Jun 10, 2021
Merged

feat(cli): LQLv2 support #441

merged 4 commits into from
Jun 10, 2021

Conversation

hazedav
Copy link
Collaborator

@hazedav hazedav commented Jun 8, 2021

Updating API and CLI to support LQLv2

  1. api-server is now returning lql_id and query_text instead of LQL_ID and QUERY_TEXT.
  2. api-server response body for lql create/update was changed.
  3. handling for lqlv2 semantics

ALLY-504

@hazedav
feat(cli): lqlv2 support
d3c3c00 
Fixing failing unit test

ALLY-504
afiune
afiune approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-243512984

@afiune afiune merged commit 8ad4abf into main Jun 10, 2021
@afiune afiune deleted the ALLY-504 branch June 10, 2021 00:35
@lacework-releng lacework-releng mentioned this pull request Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afiune afiune afiune approved these changes

@scottford-lw scottford-lw Awaiting requested review from scottford-lw

@dmurray-lacework dmurray-lacework Awaiting requested review from dmurray-lacework

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hazedav @afiune