fix(cli): non-interactive should not run daily version check #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiune
added
bug
JIRA: https://lacework.atlassian.net/browse/ALLY-551 Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
force-pushed
the
afiune/ALLY-551/cli-noninteractive
branch
from
daed6d3
to
808d250
Compare
| @@ -216,7 +216,7 @@ func (c *cliState) NewClient() error { | |||
|
|
|||
| // InteractiveMode returns true if the cli is running in interactive mode | |||
| func (c *cliState) InteractiveMode() bool { | |||
| return !c.nonInteractive && !c.csvOutput | |||
| return !c.nonInteractive && !c.csvOutput && !c.jsonOutput | |||
There was a problem hiding this comment.
This is kind of a different task than what this ticket intended. I think it's correct(non-interactive when --json flag is set), but i'd maybe consider either adding more tests for this use case or moving it out of this PR.
dmurray-lacework
approved these changes
Jun 30, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user is running in non-interactive mode, the Lacework CLI should avoid
the daily version check feature.
JIRA: https://lacework.atlassian.net/browse/ALLY-551
Signed-off-by: Salim Afiune Maya [email protected]