Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add resource group specific create functions #542

Merged
merged 8 commits into from
Sep 7, 2021

Conversation

dmurray-lacework
Copy link
Collaborator

Add specific Create functions for each resource group, to return specific type and props.

Signed-off-by: Darren Murray [email protected]

api/resource_groups_aws.go Outdated Show resolved Hide resolved
api/resource_groups_azure.go Outdated Show resolved Hide resolved
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nitpick that we agreed you will update but out of that, we are good to go!

tenor-151032375

api/resource_groups.go Outdated Show resolved Hide resolved
api/resource_groups_aws.go Outdated Show resolved Hide resolved
Signed-off-by: Darren Murray <[email protected]>
@dmurray-lacework dmurray-lacework merged commit 8a78438 into main Sep 7, 2021
@dmurray-lacework dmurray-lacework deleted the dmurray-lacework/resource-group-create branch September 7, 2021 16:21
@lacework-releng lacework-releng mentioned this pull request Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants