Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): pass-through used profile in recommendations #554

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

afiune
Copy link
Contributor

@afiune afiune commented Sep 21, 2021

Issue
Closes #540
JIRA: https://lacework.atlassian.net/browse/ALLY-634

Description:
Pass through the currently used profile in command recommendations.

Additional Info:

Screen Shot 2021-09-21 at 5 12 49 PM

Pass-through the currently used profile in command recommendations.

Closes #540

Signed-off-by: Salim Afiune Maya <[email protected]>
Copy link
Collaborator

@dmurray-lacework dmurray-lacework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Doesn't have to be for this PR, but we should consider a named func for cli outputs that are "suggestions". The func will still perform the same action but it'll be apparent where we are suggesting actions to the user

@dmurray-lacework dmurray-lacework merged commit d5340c1 into main Sep 21, 2021
@dmurray-lacework dmurray-lacework deleted the afiune/ALLY-634/pass-through-profile-flag branch September 21, 2021 15:41
This was referenced Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass-through used profile for command recommendations
2 participants