fix(cli): avoid panic when assessment has NO vulns #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Lacework CLI panics when trying to run a scan, check for a scan-status, or show the results of a container image that has NO vulnerabilities. ``` $ lacework vulnerability container scan-status 36940f74-cad7-4007-ac3d-f702f01254ba panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x1612dc6] goroutine 1 [running]: [github.com/lacework/go-sdk/cli/cmd.buildVulnContainerAssessmentReports(0xc00061e100|http://github.com/lacework/go-sdk/cli/cmd.buildVulnContainerAssessmentReports(0xc00061e100], 0x24, 0xc00061e100) /codefresh/volume/go-sdk/cli/cmd/vulnerability.go:343 +0x1e6 [github.com/lacework/go-sdk/cli/cmd.checkOnDemandContainerVulnerabilityStatus|http://github.com/lacework/go-sdk/cli/cmd.checkOnDemandContainerVulnerabilityStatus](0x7ffeefbffbb5, 0x24, 0x11bec20, 0xc0001f9cb8) /codefresh/volume/go-sdk/cli/cmd/vuln_container.go:431 +0x1bb [github.com/lacework/go-sdk/cli/cmd.glob..func37(0x1c1fa40|http://github.com/lacework/go-sdk/cli/cmd.glob..func37(0x1c1fa40], 0xc000192c70, 0x1, 0x1, 0x0, 0x0) /codefresh/volume/go-sdk/cli/cmd/vuln_container.go:82 +0x65 [github.com/spf13/cobra.(*Command).execute(0x1c1fa40|http://github.com/spf13/cobra.(*Command).execute(0x1c1fa40], 0xc000192c50, 0x1, 0x1, 0x1c1fa40, 0xc000192c50) /codefresh/volume/go-sdk/vendor/github.com/spf13/cobra/command.go:856 +0x472 [github.com/spf13/cobra.(*Command).ExecuteC(0x1c2abc0|http://github.com/spf13/cobra.(*Command).ExecuteC(0x1c2abc0], 0x2, 0x1006625, 0xc000078000) /codefresh/volume/go-sdk/vendor/github.com/spf13/cobra/command.go:974 +0x375 [github.com/spf13/cobra.(*Command).Execute(...)|http://github.com/spf13/cobra.(*Command).Execute(...)] /codefresh/volume/go-sdk/vendor/github.com/spf13/cobra/command.go:902 [github.com/lacework/go-sdk/cli/cmd.Execute|http://github.com/lacework/go-sdk/cli/cmd.Execute](0x0, 0x0) /codefresh/volume/go-sdk/cli/cmd/root.go:118 +0xa8 main.main() /codefresh/volume/go-sdk/cli/main.go:29 +0x26 ``` JIRA: https://lacework.atlassian.net/browse/ALLY-734 Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
added
bug
afiune
commented
Nov 5, 2021
| details = vulnerabilityDetailsReport{ | ||
| VulnerabilityDetails: filterVulContainerImageLayers(assessment.Image), | ||
| Packages: filterVulnContainerImagePackages(assessment.Image), | ||
| if assessment.TotalVulnerabilities == 0 { |
There was a problem hiding this comment.
This is the actual fix, but I added a bunch of tests and other checks.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Lacework CLI panics when trying to run a scan, check for a scan-status, or show
the results of a container image that has NO vulnerabilities.
Signed-off-by: Salim Afiune Maya [email protected]
How did you test this change?
Added a bunch of unit tests that should have been added on previous refactors.
Additionally, I ran a scan against an image without vulnerabilities and it worked great, as well as showing an existing assessment without vulnerabilities, the result:
Issue
JIRA: https://lacework.atlassian.net/browse/ALLY-734