-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add apply flag for aws iac generation & fix cache issues #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipcrm
force-pushed
the
ipcrm/ally_395/apply_flag
branch
from
December 15, 2021 15:09
1ee27ee
to
ffefb17
Compare
afiune
suggested changes
Dec 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rmoles
reviewed
Dec 16, 2021
ipcrm
force-pushed
the
ipcrm/ally_395/apply_flag
branch
from
December 21, 2021 02:31
698099d
to
22d8ba8
Compare
ipcrm
changed the title
feat(cli): add apply flag for aws iac generation
feat(cli): add apply flag for aws iac generation & fix cache issues
Dec 21, 2021
afiune
reviewed
Dec 22, 2021
afiune
reviewed
Dec 22, 2021
afiune
suggested changes
Dec 22, 2021
Check windows! 🪟😂 |
afiune
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Improve message on exit
ipcrm
force-pushed
the
ipcrm/ally_395/apply_flag
branch
from
January 6, 2022 15:06
4026aaa
to
7b04c98
Compare
check windows |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For AWS IaC generation; add apply flag, add cached state protections
How did you test this change?
See tests
Issue
ALLY-395