Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add apply flag for aws iac generation & fix cache issues #642

Merged
merged 10 commits into from
Jan 6, 2022

Conversation

ipcrm
Copy link
Contributor

@ipcrm ipcrm commented Dec 15, 2021

Summary

For AWS IaC generation; add apply flag, add cached state protections

How did you test this change?

See tests

Issue

ALLY-395

Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, left a few comments.

tenor-58718559

cli/cmd/generate_execute.go Outdated Show resolved Hide resolved
cli/cmd/generate_execute.go Outdated Show resolved Hide resolved
cli/cmd/generate_execute.go Outdated Show resolved Hide resolved
@ipcrm ipcrm changed the title feat(cli): add apply flag for aws iac generation feat(cli): add apply flag for aws iac generation & fix cache issues Dec 21, 2021
@ipcrm ipcrm marked this pull request as ready for review December 21, 2021 02:37
@ipcrm ipcrm requested a review from afiune December 21, 2021 14:08
cli/cmd/generate_terraform_test.go Outdated Show resolved Hide resolved
@afiune
Copy link
Contributor

afiune commented Dec 22, 2021

Check windows! 🪟😂

@ipcrm ipcrm requested a review from afiune December 22, 2021 14:50
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-265848016

@ipcrm
Copy link
Contributor Author

ipcrm commented Jan 6, 2022

check windows

@ipcrm ipcrm merged commit c5014bb into main Jan 6, 2022
@ipcrm ipcrm deleted the ipcrm/ally_395/apply_flag branch January 6, 2022 16:25
@lacework-releng lacework-releng mentioned this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants