Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): clarify container error message #643

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Conversation

afiune
Copy link
Contributor

@afiune afiune commented Dec 15, 2021

Summary

An error like this is confusing:

ERROR container image '[image]:[tag]' not found in registry '[registry].

A better error message to reference an image and tag should be:

ERROR container image '[image]@[tag]' not found in registry '[registry].

How did you test this change?

Ran a scan against an image that doesn't exist, also updated the tests.

Issue

Via @alannix-lw

@afiune afiune force-pushed the afiune/fix-cli-error-message branch from 2e81a1b to 010d7fb Compare December 15, 2021 20:18
@afiune afiune merged commit 74592ff into main Dec 16, 2021
@afiune afiune deleted the afiune/fix-cli-error-message branch December 16, 2021 16:04
@lacework-releng lacework-releng mentioned this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants