Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(iac-generation): update aws iac tf command help #653

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Conversation

ipcrm
Copy link
Contributor

@ipcrm ipcrm commented Jan 12, 2022

Summary

Fix aws tf generate command docs strings

How did you test this change?

N/A

Issue

N/A

@@ -54,7 +54,7 @@ var (
// aws command is used to generate TF code for aws
generateAwsTfCommand = &cobra.Command{
Use: "aws",
Short: "Genereate terraform code for deploying into a new AWS environment",
Short: "Generate and optionally execute terraform code for deploying into a new AWS environment",
Copy link
Contributor

@afiune afiune Jan 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhmmm**, my gut tells me that this is no longer a Short description 😂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, i mean by comparison to the long description it's short.

@afiune
Copy link
Contributor

afiune commented Jan 14, 2022

Check windows!

cli/cmd/generate.go Outdated Show resolved Hide resolved
@ipcrm
Copy link
Contributor Author

ipcrm commented Jan 18, 2022

@ipcrm ipcrm requested review from afiune and rmoles January 18, 2022 13:30
cli/cmd/generate.go Outdated Show resolved Hide resolved
cli/cmd/generate.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afiune afiune merged commit 5c09072 into main Jan 24, 2022
@afiune afiune deleted the ipcrm/iac-docs branch January 24, 2022 21:06
@lacework-releng lacework-releng mentioned this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants