feat(cli): update query by loading it from the platform #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiune
commented
Mar 4, 2022
| assert.Empty(t, err.String(), "STDERR should be empty") | ||
| assert.Equal(t, 0, exitcode, "EXITCODE is not the expected one") | ||
| } | ||
|
|
There was a problem hiding this comment.
This is already covered globally! Kuddos to @hazedav
dmurray-lacework
approved these changes
Mar 8, 2022
afiune
force-pushed
the
afiune/ALLY-875/update-loads-query-from-account
branch
from
efab411
to
35185f5
Compare
As a Lacework CLI user, I want to update a query without having to type the query again, So I can modify my queries faster via inline modifications. This change is adding the ability to load a query into the default editor from the user so that they can easily make inline modifications. Simply run the command `lacework query update [query_id]` and an editor will open with the query preloaded, modify it, save and close the file for the Lacework CLI to apply those modifications. Signed-off-by: Salim Afiune Maya <[email protected]>
Signed-off-by: Salim Afiune Maya <[email protected]>
Signed-off-by: Salim Afiune Maya <[email protected]>
Signed-off-by: Salim Afiune Maya <[email protected]>
Signed-off-by: Salim Afiune Maya <[email protected]>
Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
force-pushed
the
afiune/ALLY-875/update-loads-query-from-account
branch
from
35185f5
to
21e8d5b
Compare
Signed-off-by: Salim Afiune Maya <[email protected]>
Signed-off-by: Salim Afiune Maya <[email protected]>
This reverts commit 5edd9b6.
|
Modified the pipeline to install vim via: |
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Story
As a Lacework CLI user,
I want to update a query without having to type the query again,
So I can modify my queries faster via inline modifications.
Summary
This change is adding the ability to load a query into the default
editor from the user so that they can easily make inline modifications.
Simply run the command
lacework query update [query_id]and an editorwill open with the query preloaded, modify it, save and close the file
for the Lacework CLI to apply those modifications.
Signed-off-by: Salim Afiune Maya [email protected]
How did you test this change?
Ran it locally to do an inline editing:
Issue
https://lacework.atlassian.net/browse/ALLY-875