feat: show query start time in progress spinner #798
Conversation
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
| cli.StartProgress(" Executing query...") | ||
| msg := "Executing query" | ||
| startTime, startErr := time.Parse(time.RFC3339, args[0].Value) | ||
| endTime, endErr := time.Parse(time.RFC3339, args[1].Value) |
There was a problem hiding this comment.
I feel the way this function is written allows us to make easy mistakes such as 1) having the arguments in a different order and getting the start/end time wrong, and 2) passing less than two arguments which will throw a panic trying to access elements that don't exist since we are not checking that the array has at least two elements.
There are no unit tests for this function.
@hazedav @dmurray-lacework let's improve this code so we don't leave room for human mistakes. It can be done with further PRs, but let us not forget about this. Please.
There was a problem hiding this comment.
👍 created an issue for this @afiune https://lacework.atlassian.net/browse/ALLY-1015
| cli.StartProgress(" Executing query...") | ||
| msg := "Executing query" | ||
| startTime, startErr := time.Parse(time.RFC3339, args[0].Value) | ||
| endTime, endErr := time.Parse(time.RFC3339, args[1].Value) |
There was a problem hiding this comment.
Same for this function runAdhocQuery()
Signed-off-by: Darren Murray [email protected]
Summary
When running the
lacework query runcommand, display the start time and end time of time range the query is executing in the progress spinner.How did you test this change?
run cmd
lacework query run <query-id>lacework query run <query-id> --start -1hrexample output:
Issue
https://lacework.atlassian.net/browse/ALLY-938