feat(cli): add --details flag to vulnerability cmd #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
force-pushed
the
afiune/ALLY-93/vulnerability--details
branch
from
2b6b7dd
to
646943a
Compare
This change is adding a new flag to the vulnerability command called `--details`, this flag will extend the report shown to the end-user. The new information presented with this flag is the list of CVE's with its severity, version and, if any, fix version, plus the layer that the vulnerability was introduced by. Example: ``` $ lacework vulnerability report sha256:123ab...xyz --details ``` This flag is available to all sub-commands inside the `vulnerability` cmd. (`scan run`, `scan show`, and `report` as shown above) Closes #82 Signed-off-by: Salim Afiune Maya <[email protected]>
ghost
force-pushed
the
afiune/ALLY-93/vulnerability--details
branch
from
646943a
to
227a7b2
Compare
Signed-off-by: Salim Afiune Maya <[email protected]>
Signed-off-by: Salim Afiune Maya <[email protected]>
scottford-lw
approved these changes
Apr 28, 2020
Signed-off-by: Salim Afiune Maya <[email protected]>
|
The team continues to review the output displayed, as of this message, the current output
An open question is:
Another alternative is to display the entire content of the layer, this could make
Any feedback would be highly appreciated! 💯 |
We have received feedback that indicates that showing the HASH of the layer is a little bit obscure, we are switching to display the content of the layer instead, with that, users will have immediate feedback and understanding of where vulnerabilities come from. Signed-off-by: Salim Afiune Maya <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is adding a new flag to the vulnerability command called
--details, this flag will extend the report shown to the end-user.The new information presented with this flag is the list of CVE's with
its severity, version and, if any, fix version, plus the layer that the
vulnerability was introduced by.
Example:
This flag is available to all sub-commands inside the
vulnerabilitycmd. (
lacework vul scan run,lacework vul scan show, andlacework vul report, as shown above 👆🏽)Closes #82
Signed-off-by: Salim Afiune Maya [email protected]