-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): policy exceptions crud #844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darren Murray <[email protected]>
dmurray-lacework
force-pushed
the
dmurray-lacework/ALLY-1060
branch
from
July 5, 2022 10:11
12be69a
to
b6e4d0b
Compare
Signed-off-by: Darren Murray <[email protected]>
afiune
reviewed
Jul 7, 2022
afiune
reviewed
Jul 7, 2022
afiune
reviewed
Jul 7, 2022
afiune
reviewed
Jul 7, 2022
afiune
reviewed
Jul 7, 2022
afiune
reviewed
Jul 7, 2022
afiune
reviewed
Jul 7, 2022
afiune
reviewed
Jul 7, 2022
afiune
reviewed
Jul 7, 2022
Co-authored-by: Salim Afiune <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
afiune
reviewed
Jul 12, 2022
cli/cmd/policy_exceptions.go
Outdated
policyExceptionListCmd = &cobra.Command{ | ||
Use: "list <policy_id>", | ||
Aliases: []string{"ls"}, | ||
Short: "List policy exceptions", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Short: "List policy exceptions", | |
Short: "List all exceptions from a policy", |
Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
approved these changes
Jul 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darren Murray [email protected]
Summary
Add new commands to manage Lacework policy exceptions using the CLI
How did you test this change?
Run new commands
lacework policy-exception list
lacework policy-exception list [policy-id]
lacework policy-exception show [policy-id] [exception-id]
lacework policy-exception delete [policy-id] [exception-id]
lacework policy-exception create
Issue
https://lacework.atlassian.net/browse/ALLY-1060