Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): policy exceptions crud #844

Merged
merged 10 commits into from
Jul 12, 2022
Merged

feat(cli): policy exceptions crud #844

merged 10 commits into from
Jul 12, 2022

Conversation

dmurray-lacework
Copy link
Collaborator

@dmurray-lacework dmurray-lacework commented Jul 1, 2022

Signed-off-by: Darren Murray [email protected]

Summary

Add new commands to manage Lacework policy exceptions using the CLI

How did you test this change?

Run new commands
lacework policy-exception list
lacework policy-exception list [policy-id]
lacework policy-exception show [policy-id] [exception-id]
lacework policy-exception delete [policy-id] [exception-id]
lacework policy-exception create

Issue

https://lacework.atlassian.net/browse/ALLY-1060

@dmurray-lacework dmurray-lacework marked this pull request as ready for review July 5, 2022 10:14
cli/cmd/policy_exceptions.go Outdated Show resolved Hide resolved
cli/cmd/policy_exceptions.go Outdated Show resolved Hide resolved
cli/cmd/policy_exceptions.go Outdated Show resolved Hide resolved
cli/cmd/policy_exceptions.go Outdated Show resolved Hide resolved
cli/cmd/policy_exceptions.go Outdated Show resolved Hide resolved
cli/cmd/policy_exceptions.go Outdated Show resolved Hide resolved
cli/cmd/policy_exceptions.go Outdated Show resolved Hide resolved
cli/cmd/policy_exceptions.go Outdated Show resolved Hide resolved
cli/cmd/policy_exceptions.go Outdated Show resolved Hide resolved
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
policyExceptionListCmd = &cobra.Command{
Use: "list <policy_id>",
Aliases: []string{"ls"},
Short: "List policy exceptions",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Short: "List policy exceptions",
Short: "List all exceptions from a policy",

Signed-off-by: Salim Afiune Maya <[email protected]>
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-108200641

@afiune afiune merged commit 7e894c9 into main Jul 12, 2022
@afiune afiune deleted the dmurray-lacework/ALLY-1060 branch July 12, 2022 04:38
@lacework-releng lacework-releng mentioned this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants