Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add v2 AwsCfg #889

Merged
merged 4 commits into from
Aug 18, 2022
Merged

feat(api): add v2 AwsCfg #889

merged 4 commits into from
Aug 18, 2022

Conversation

dmurray-lacework
Copy link
Collaborator

Summary

Add AwsCfg to CloudAccountsService

How did you test this change?

Run new example _examples/cloud-accounts/aws-cfg/main.go

Issue

https://lacework.atlassian.net/browse/ALLY-1155

Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update generateCloudAccounts() function, there is a TODO I left there.

@@ -0,0 +1,57 @@
//
// Author:: Darren Murray (<[email protected]>)
// Copyright:: Copyright 2021, Lacework Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are in 2022 😅

@afiune afiune changed the title feat: add v2 AwsCfg feat(api): add v2 AwsCfg Aug 18, 2022
Signed-off-by: Darren Murray <[email protected]>
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-167448684

@dmurray-lacework dmurray-lacework merged commit 53bd1ca into main Aug 18, 2022
@dmurray-lacework dmurray-lacework deleted the dmurray-lacework/ALLY-1132 branch August 18, 2022 15:16
@lacework-releng lacework-releng mentioned this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants