-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add v2 AwsCfg #889
Conversation
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update generateCloudAccounts()
function, there is a TODO I left there.
api/cloud_accounts_aws_cfg.go
Outdated
@@ -0,0 +1,57 @@ | |||
// | |||
// Author:: Darren Murray (<[email protected]>) | |||
// Copyright:: Copyright 2021, Lacework Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are in 2022 😅
Signed-off-by: Darren Murray <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Add
AwsCfg
toCloudAccountsService
How did you test this change?
Run new example
_examples/cloud-accounts/aws-cfg/main.go
Issue
https://lacework.atlassian.net/browse/ALLY-1155