refactor(cli): migrate cmd compliance aws|gcp|azure get-report #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmurray-lacework
force-pushed
the
dmurray-lacework/ALLY-1212
branch
2 times, most recently
from
e22d7ea
to
847a462
Compare
Signed-off-by: Darren Murray <[email protected]>
dmurray-lacework
force-pushed
the
dmurray-lacework/ALLY-1212
branch
from
6f2da75
to
327a902
Compare
rmoles
reviewed
Oct 20, 2022
rmoles
approved these changes
Oct 20, 2022
Signed-off-by: Darren Murray <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the command
compliance aws|gcp|azure get-report <id>to use the v2 apiHow did you test this change?
Update
compliance_aws_test.goandcompliance_test.gowith v2 mock responses.Manually run:
compliance aws|gcp|azure get-report <id>compliance aws|gcp|azure get-report <id> --detailscompliance aws|gcp|azure get-report <id> --jsoncompliance aws|gcp|azure get-report <id> [rec_id]Issue
https://lacework.atlassian.net/browse/ALLY-1212