fix: compliance evaluation search cmd, searches greater than last 7 days #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmurray-lacework
changed the title
dmurray-lacework
force-pushed
the
dmurray-lacework/ALLY-1196-alt
branch
from
26aad95
to
79acf4a
Compare
afiune
suggested changes
Nov 15, 2022
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]> refactor: use single windowSearch func
Signed-off-by: Darren Murray <[email protected]>
dmurray-lacework
force-pushed
the
dmurray-lacework/ALLY-1196-alt
branch
from
3f43339
to
496a6a7
Compare
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
Signed-off-by: Darren Murray <[email protected]>
afiune
reviewed
Nov 15, 2022
afiune
reviewed
Nov 15, 2022
Signed-off-by: Darren Murray <[email protected]>
afiune
approved these changes
Nov 15, 2022
Signed-off-by: Darren Murray <[email protected]>
Merged
This was referenced Nov 28, 2022
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternate approach to #976
Allows wrapping any
searchtypetype search func(response interface{}, filters SearchableFilter) errorin a WindowedSearch()Summary
The compliance evaluation search cmd was only searching the last 7 days. The max amount of days allowed for this search is 92, with a window of 7 days.
This change adds a new windowedSearch func to perform a new search of a specific time frame size until response data is found or the max searchable days is reached
How did you test this change?
Run
lacework aws comp search <resource_arn>with the resource arn from JIRA acceptance criteriaAdded new unit tests
Issue
https://lacework.atlassian.net/browse/ALLY-1196